This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
ethers: Fix encodeTxForRPC to separately handle 0x and 0x0 #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blukat29
requested review from
kjeom,
nohkwak and
JayChoi1736
as code owners
blukat29
changed the title
blukat29
force-pushed
the
fix-encodetxrpc
branch
from
ac25f42
to
1dfadf8
Compare
kjeom
approved these changes
Sep 15, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling some RPCs (eth_estimateGas, eth_call), the transaction arguments must be properly hexlified.
(https://github.com/klaytn/klaytn/blob/dev/api/tx_args.go#L536)
Zero numeric values must be encoded to "0x0" and
Empty bytes and address values must be "0x".